upadte 2d20 roll and damage roll #380
Conversation
upadate to noew dev baranch
change for 2d20 roll : - add automatization for buing d20 dice including PC and GM, allow to buy dice for GM AP - add button for assistance, always will roll 1d20 - reduce ammo for GM (option i settings) - reduce 10 amo for gatling guns change for damage roll : - for guns fire rate can be add at begining of rolling, read weapon property and chcek if we have enough amo to shoot more bullet - for mele/unarmed can spend max 3 AP for PC and GM - reduce AP if avaliable for both PC and GM - for PC buy from GM, with notification, add to GM AP automaticaly - add button from chat read weapon fire rate and chcek avaliable amo
|
I'll try and take a look at this after the next release. I think it looks like it might need a bit of beautification before it can go into a release, judging by the screenshots you've shared. |
|
I was not spending much time on css just to look reasonable fine |
i18n/pl.yaml
Outdated
There was a problem hiding this comment.
Please don't check in changes to the non en.yaml translation files, any changes will be overwritten with the next sync from Crowdin anyway.
i18n/en.yaml
Outdated
| FALLOUT.UI.Additionalamo: Additional damage dice from firerate | ||
| FALLOUT.UI.Additionalmeledmg: Additional damage dice for party AP | ||
| FALLOUT.UI.AdditionalmeledmgOverseer: Additional damage dice for overseer AP |
There was a problem hiding this comment.
As mentioned in your other pull request, please try and keep keys readable. Going forward I'm trying to standardise the i18n key style to snake_case, avoiding unecessary abbreviations where possible
system/src/roller/Dialog2d20.mjs
Outdated
There was a problem hiding this comment.
There are several instances in this file where function/method names are hard to read being all lower-case with multiple words merged together.
Please make sure all function/methods names in camelCaseFormat.
Also, any new html being rendered should be done via relevant template files, not embedded in code please. I'm gradually stripping out existing instances of that.
system/src/roller/DialogD6.mjs
Outdated
There was a problem hiding this comment.
There are similar problems in this file as mentioned in the comment for Dialog2d20.mjs
| @@ -132,7 +132,7 @@ export default class FalloutChat { | |||
| const falloutRoll = message.flags.falloutroll; | |||
| const weapon = message.flags.weapon; | |||
|
|
|||
| fallout.DialogD6.createDialog({ | |||
| fallout.DialogD6.addcreateDialog({ | |||
There was a problem hiding this comment.
Method names should be camelCaseStyle
system/system.json
Outdated
There was a problem hiding this comment.
This change breaks the manifest config settings. Please don't make changes to system.json
in pl.yaml I delete added elements
|
I do all mentioned request, as well fixing few issue that I recognie like macros for rollind d6 or 2d20 |
|
Having had a play around with this, I really don't like the workflow changes this makes to the dice rolling, as it feels quite clunky and unintuitive. I'm afraid I'm going to have to reject this one as it would be more work to resolve the issues with this implementation than it would be to write the new dice roller I'd already envisioned replacing the existing one. |
change for 2d20 roll :
change for damage roll :